Check reference

Back a declared change type with evidence

Calling a change a refactor, fix, or feature creates different review obligations. change_evidence_complete checks the backing records promised by that declaration.

What the check observes

For in-branch changed Go production artifacts, a typed impact review must carry the expected backing. A refactor uses a no-authored-change decision. A fix links a resolvable defect with a non-open closure disposition and affected-code entry for the artifact. A feature links a LocalChange of type feature that lists the reviewing requirement. The requirement list is the implemented spec-update signal; the check does not independently prove that the specification change is adequate.

Example: a fix points to the wrong defect scope

Illustrative case. An impact review calls an edit to retry.go a fix, but its linked defect only lists timeout.go. The ID resolves, yet the record does not account for this artifact. Correct the actual defect impact analysis before using it as backing.

# Illustrative review after the defect evidence is ready
proof review impact SYS-REQ-042 \
  --change-type fix --defect DEFECT-17 \
  --reason "Repair for DEFECT-17; retry.go is included in its affected-code analysis"

Resolve the finding

Read the declared type and the exact missing-backing finding.
For a fix, investigate and disposition the real defect, including affected artifacts and regression evidence. For a feature, record the delivered behavior and its governing requirement.
Keep the classification truthful. Do not relabel a fix as a refactor or remove the declaration to fall outside the check.

Run and interpret

proof audit --check change_evidence_complete --verbose \
  --set project.checks.change_evidence_complete.enabled=true

This verify-stage warning is off by default. Reviews without a declared change type are not flagged. Test files, generated/local state, and artifacts outside the in-branch changed set are excluded.

A resolvable backing record is not proof that a defect is fixed, that a regression runs, or that an entire defect class is closed. Those conclusions need their own scoped evidence. The audit CLI defaults to failing on warnings unless overridden.

Continue from here

Review newly exported Go surface. Bind impact reviews to current intent.

Bring one disputed change classification with its code delta and defect or change record. Bring a change to Proof.